Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] #36085

Merged
merged 2 commits into from
May 6, 2019
Merged

[email protected] #36085

merged 2 commits into from
May 6, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented May 5, 2019

Summary

  • Added display prop to EuiTabs and EuiTabbedContent components for ability to use an alternative condensed style (#1904)

@snide snide requested a review from a team as a code owner May 5, 2019 05:38
@snide snide requested a review from chandlerprall May 5, 2019 05:38
@elasticmachine
Copy link
Contributor

💔 Build Failed

@chandlerprall
Copy link
Contributor

EuiHeaderLogo was converted to typescript and missed a changelog entry; this change brought to light an existing small bug in Kibana code which expected an HTMLButtonElement where EUI uses an HTMLAnchorElement. Pushed a fix for this to @snide's branch.

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending green CI, package, snapshot, and yarn.lock changes look good to me

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@snide
Copy link
Contributor Author

snide commented May 6, 2019 via email

@snide snide merged commit d1b1894 into elastic:master May 6, 2019
@snide snide deleted the eui/10.4.0 branch May 6, 2019 04:37
snide added a commit to snide/kibana that referenced this pull request May 6, 2019
* [email protected]

* Fix TS typing in src/legacy/ui/public/chrome/directives/header_global_nav/components/header.tsx
snide added a commit that referenced this pull request May 6, 2019
* [email protected]

* Fix TS typing in src/legacy/ui/public/chrome/directives/header_global_nav/components/header.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants